It is currently Sat Aug 22, 2020 2:50 pm


All times are UTC




Post new topic Reply to topic  [ 150 posts ]  Go to page Previous  1 ... 5, 6, 7, 8, 9, 10, 11 ... 15  Next
Author Message
 Post subject: Re: Streaming Volume
PostPosted: Wed Mar 09, 2011 10:25 pm 
Developer
User avatar

Joined: Sun May 04, 2008 6:35 pm
Posts: 1827
ker wrote:
ok... or that way, it's probably better. I'll not change polyvox then until I get your cleaned up version.

Ok, great. I'll try to make some progress over the weekend :)

Also, does anyone else hate the smiley's on this forum? The guy looks really uncomfortable :)


Top
Offline Profile  
Reply with quote  
 Post subject: Re: Streaming Volume
PostPosted: Wed Mar 09, 2011 11:36 pm 
Developer
User avatar

Joined: Sun May 11, 2008 4:29 pm
Posts: 198
Location: UK
David Williams wrote:
Also, does anyone else hate the smiley's on this forum? The guy looks really uncomfortable :)
Yeah, they look a bit awkward :shock:. Maybe I'll have a look for a better smiley pack. Perhaps one with a better alpha channel to get rid of the white border.

_________________
Matt Williams
Linux/CMake guy


Top
Offline Profile  
Reply with quote  
 Post subject: Re: Streaming Volume
PostPosted: Wed Mar 09, 2011 11:48 pm 

Joined: Tue Mar 08, 2011 3:57 am
Posts: 46
Well, this forum looks like its from 1995. :P
You really need a completely new theme hah.


Top
Offline Profile  
Reply with quote  
 Post subject: Re: Streaming Volume
PostPosted: Thu Mar 10, 2011 7:02 pm 
Developer
User avatar

Joined: Sun May 04, 2008 6:35 pm
Posts: 1827
milliams wrote:
Yeah, they look a bit awkward :shock:. Maybe I'll have a look for a better smiley pack. Perhaps one with a better alpha channel to get rid of the white border.

Sure, if you can find something that would be great. I'm sure it's not hard I've just never looked into it.
DJDD wrote:
Well, this forum looks like its from 1995. :P
You really need a completely new theme hah.

Yeah, we've been talking about a new website, possibly some time in the next six months. And we'll probably avoid white text on a dark background next time - I'm pretty sure nobody uses that any more :)


Top
Offline Profile  
Reply with quote  
 Post subject: Re: Streaming Volume
PostPosted: Thu Mar 10, 2011 7:04 pm 

Joined: Fri Feb 18, 2011 8:41 pm
Posts: 173
David Williams wrote:
Yeah, we've been talking about a new website, possibly some time in the next six months. And we'll probably avoid white text on a dark background next time - I'm pretty sure nobody uses that any more :)


Put it orange on yellow!


Top
Offline Profile  
Reply with quote  
 Post subject: Re: Streaming Volume
PostPosted: Thu Mar 10, 2011 8:09 pm 
Developer
User avatar

Joined: Sun May 04, 2008 6:35 pm
Posts: 1827
I'll be sure to keep that in mind ;)


Top
Offline Profile  
Reply with quote  
 Post subject: Re: Streaming Volume
PostPosted: Fri Mar 11, 2011 10:24 pm 
Developer
User avatar

Joined: Sun May 04, 2008 6:35 pm
Posts: 1827
@ker - Ok, I've started looking at this.

First I commited you patch exactly how it was, so that at least should work for you.

Next I fixed some compile errors, particularly with Boost. Actually, I have found that when the load and unload functions are std::function there is no need to use std::bind in order to set them up. I do not know if this is also true with Boost. Maybe you can verify? The code now looks like this:

Code:
volData.m_LoadCallback = &load;
volData.m_UnloadCallback = &unload;
//volData.m_LoadCallback = polyvox_bind(&load, polyvox_placeholder_1, polyvox_placeholder_2);
//volData.m_UnloadCallback = polyvox_bind(&unload, polyvox_placeholder_1, polyvox_placeholder_2);


Lastly, I have reverted some of your commit in order to bring back the concept of volume width, height, and depth. Actually I'm still working on tidying up the interface here, but the idea will be that every volume will be a fixed size, but if you don't specify a size it will default to the maximum size allowed by int32_t (which is pretty close to infinite).

I also reverted the OpenGL example so it uses a fixed size volume again, while the BasicExample is still testing the streaming. I'm trying to keep both these examples working at all times, so any commit I make should continue to work for you. Let me know if I break something in your project...


Top
Offline Profile  
Reply with quote  
 Post subject: Re: Streaming Volume
PostPosted: Sat Mar 12, 2011 6:11 am 

Joined: Fri Feb 18, 2011 8:41 pm
Posts: 173
Nothing ever gets close to infinity :P

So to make it clear, now we can set size like 1028 and getVoxel(2000) will be invalid again, no matter streaming?

If we ask for getVoxel(500) it will call the streaming functions as discussed before? So kind of combining the two ways?

And if no size is specified, the size is just huge anyway and streaming, again as before?

Wondering as it means I should edit the editor I posted to use region.CropTo to avoid illegal voxels editing.


Top
Offline Profile  
Reply with quote  
 Post subject: Re: Streaming Volume
PostPosted: Sat Mar 12, 2011 8:54 am 
Developer
User avatar

Joined: Sun May 04, 2008 6:35 pm
Posts: 1827
Shanee wrote:
Nothing ever gets close to infinity :P

Well, it's closer than it was before. But I'm pretty sure mathmaticians would disagree with me there ;)
Shanee wrote:
So to make it clear, now we can set size like 1028 and getVoxel(2000) will be invalid again, no matter streaming?

Yes, that's correct. Or do you think that doesn't make sense for some reason?
Shanee wrote:
If we ask for getVoxel(500) it will call the streaming functions as discussed before? So kind of combining the two ways?

I think that if you specify a size the streaming will probably be disabled by default, but there'll be a bool parameter to the constructor to override this. So yes, provided you enable streaming it will work as before.
Shanee wrote:
And if no size is specified, the size is just huge anyway and streaming, again as before?

Yep, that's right.
Shanee wrote:
Wondering as it means I should edit the editor I posted to use region.CropTo to avoid illegal voxels editing.

Maybe... but decisions aren't final yet so don't go out of your way to adapt. If you think something doesn't make sense then just say.


Top
Offline Profile  
Reply with quote  
 Post subject: Re: Streaming Volume
PostPosted: Sat Mar 12, 2011 11:24 am 

Joined: Fri Feb 18, 2011 8:41 pm
Posts: 173
I think it all makes sense. Allowing streaming for specific size makes sense, also allowing non streaming makes sense, boolean could do well.

Only thing which might not make sense is the max int as size, though it isn't bad at all considering how big it is, I know I doubt I'd ever need more, after all -62k to 62k is quite a bit. Though some others might want the option for more. I am personally not too concerned.

Oh that brings another question, can we go to negative numbers now? How? We couldn't before, could we? Can you elaborate on that please?

Thank you :)

P.S. I think have the min-max int for "infinite" volumes is good cause then I know for my own personal use that I can keep the crop region logic which may serve for multi-case volumes, specific size can use it and it won't break functionality in non-specific size terrain. I believe it will allow both users of the different volume types to easily switch from one to the other and not breaking their code horribly, as well as allowing them have just one class to handle both cases in a very simple and easy manner. I say keep it :)


Top
Offline Profile  
Reply with quote  
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 150 posts ]  Go to page Previous  1 ... 5, 6, 7, 8, 9, 10, 11 ... 15  Next

All times are UTC


Who is online

Users browsing this forum: No registered users and 5 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group
Theme created StylerBB.net