It is currently Mon Dec 16, 2019 10:47 am


All times are UTC




Post new topic Reply to topic  [ 24 posts ]  Go to page Previous  1, 2, 3
Author Message
 Post subject: Re: New Volume class with improved compression
PostPosted: Mon Feb 21, 2011 1:22 pm 
User avatar

Joined: Wed Jan 26, 2011 3:20 pm
Posts: 203
Location: Germany
RLE won't compile for me
it needs an
Code:
#include <limits>

in
Code:
library/PolyVoxCore/include/PolyVoxImpl/Block.h

after that the examples work fine

you should write to the upgrade notes that all calls to tidyUpMemory() need to be removed since it doesn't exist anymore

and while we're at it, Filters.inl doesn't need the #include "MaterialDensityPair.h" and the occurrance of MaterialDensityPair44 needs to be replaced by VoxelType (not related to RLE)

moving my project from PolyVox-trunk to RLE worked without any mentionable troubles


Top
Offline Profile  
Reply with quote  
 Post subject: Re: New Volume class with improved compression
PostPosted: Mon Feb 21, 2011 8:52 pm 
Developer
User avatar

Joined: Sun May 04, 2008 6:35 pm
Posts: 1827
Thanks, I'm not going to get any development done this week but I'll make a note to fix those things before doing the merge into the trunk.


Top
Offline Profile  
Reply with quote  
 Post subject: Re: New Volume class with improved compression
PostPosted: Wed Feb 23, 2011 8:16 am 
User avatar

Joined: Wed Jan 26, 2011 3:20 pm
Posts: 203
Location: Germany
I don't think anyone here will complain if it takes time... You have done great things for us, for greater things we'll just need patience ;)

I had some odd things happening for small block side lengths :D took me a while to figure it out, I don't fill my whole volume, usually that meant it's "empty" filled with VoxelType()...
but basically I was getting the data from other blocks...

I believe the Block::initialise function needs this:

Code:
      uint32_t uNoOfVoxels = m_uSideLength * m_uSideLength * m_uSideLength;
      RunlengthEntry<uint16_t> entry;
      entry.length = uNoOfVoxels;
      entry.value = VoxelType();
      m_vecCompressedData.push_back(entry);

at least it works for Material8, I'm not sure about other materials and how they should behave


Top
Offline Profile  
Reply with quote  
 Post subject: Re: New Volume class with improved compression
PostPosted: Wed Feb 23, 2011 8:22 pm 
Developer
User avatar

Joined: Sun May 04, 2008 6:35 pm
Posts: 1827
Ah, thanks. Actually I have seen there is a bug somewhere (there has been a problem with the extracted meshes using the new Volume) but I hadn't tracked it down yet. Hopefully your change will fix it :-)


Top
Offline Profile  
Reply with quote  
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 24 posts ]  Go to page Previous  1, 2, 3

All times are UTC


Who is online

Users browsing this forum: No registered users and 3 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group
Theme created StylerBB.net