It is currently Mon Feb 24, 2020 5:39 pm


All times are UTC




Post new topic Reply to topic  [ 2 posts ] 
Author Message
 Post subject: SurfaceMesh::extractSubset
PostPosted: Sun Jan 23, 2011 3:31 pm 

Joined: Sun Jan 23, 2011 6:06 am
Posts: 92
Hello

Just thought I might mention that SurfaceMesh.inl line 354 - 356 for function SurfaceMesh::extractSubset which currently looks like this:

PositionMaterialNormal& v0 = m_vecVertices[m_vecTriangleIndices[triCt]];
PositionMaterialNormal& v1 = m_vecVertices[m_vecTriangleIndices[triCt + 1]];
PositionMaterialNormal& v2 = m_vecVertices[m_vecTriangleIndices[triCt + 2]];

should be this:

VertexType& v0 = m_vecVertices[m_vecTriangleIndices[triCt]];
VertexType& v1 = m_vecVertices[m_vecTriangleIndices[triCt + 1]];
VertexType& v2 = m_vecVertices[m_vecTriangleIndices[triCt + 2]];

otherwise it is not possible to extractSubset on a SurfaceMesh<PositionMaterial> such as when extracting multiple materials from a cubic surface without normals. To do so results in compile error unable to convert PositionMaterial& to PositionMaterialNormal&


Top
Offline Profile  
Reply with quote  
 Post subject: Re: SurfaceMesh::extractSubset
PostPosted: Sun Jan 23, 2011 5:45 pm 
Developer
User avatar

Joined: Sun May 04, 2008 6:35 pm
Posts: 1827
Thanks for the heads up, this has been fixed.

When you update, be aware that extractSubset() is now a free function, rather than being a member of SurfaceMesh. As a member it was causing problems with the SWIG bindings. I'm not using this function myself, so I've done the move without really testing it (except that it still compiles). So let me know if you have any further problems with it...


Top
Offline Profile  
Reply with quote  
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 2 posts ] 

All times are UTC


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group
Theme created StylerBB.net